Skip to content

Commit b696500

Browse files
committed
[lld/mac] Stop accepting arbitrary suffixes on --(no-)warn-dylib-install-name
The flag accidentally used Joined<> instead of Flag<>. Previously, `--warn-dylib-install-namefoobarbaz` would be accepted and had the same effect as `-warn-dylib-install-name`. Now the flag only works if no suffix is attached to it, as originally intended. Also fix a typo in the flag's help text. Differential Revision: https://reviews.llvm.org/D131781
1 parent 8fc0024 commit b696500

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lld/MachO/Options.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ def start_lib: Flag<["--"], "start-lib">,
7777
HelpText<"Start a grouping of objects that should be treated as if they were together in an archive">;
7878
def end_lib: Flag<["--"], "end-lib">,
7979
HelpText<"End a grouping of objects that should be treated as if they were together in an archive">;
80-
def no_warn_dylib_install_name: Joined<["--"], "no-warn-dylib-install-name">,
81-
HelpText<"Do not warn on -install-name if -dylib is not passed (default)">,
80+
def no_warn_dylib_install_name: Flag<["--"], "no-warn-dylib-install-name">,
81+
HelpText<"Do not warn on -install_name if -dylib is not passed (default)">,
8282
Group<grp_lld>;
83-
def warn_dylib_install_name: Joined<["--"], "warn-dylib-install-name">,
84-
HelpText<"Warn on -install-name if -dylib is not passed">,
83+
def warn_dylib_install_name: Flag<["--"], "warn-dylib-install-name">,
84+
HelpText<"Warn on -install_name if -dylib is not passed">,
8585
Group<grp_lld>;
8686
def call_graph_profile_sort: Flag<["--"], "call-graph-profile-sort">,
8787
HelpText<"Reorder sections with call graph profile (default)">,

0 commit comments

Comments
 (0)