-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes #11635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11635 +/- ##
==========================================
- Coverage 91.90% 89.93% -1.98%
==========================================
Files 199 199
Lines 24363 24380 +17
==========================================
- Hits 22390 21925 -465
- Misses 1973 2455 +482
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… to select from all configurable nodes
…ethod from SelectorMethod class
3179d46 to
5d37b84
Compare
QMalcolm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ This looks great! One thing though, we should add some tests! I think the most appropriate place would be to add them to tests/functional/selectors/
|
@QMalcolm added some unit & functional tests! |
QMalcolm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you so much!
Resolves #11607
Problem
Today, our ConfigSelectorMethod supports selection from parsed and source nodes only.
As an example, you can do this
dbt ls -s config.meta.contains_pii:true, but this command won't return any semantic layer saved queries that have this meta key in the config, despite us using configs for other purposes (as documented).Solution
This PR changes the nodes used by the
ConfigSelectorMethodto useall_nodesmethod instead ofconfigurable_nodes. It's the case thatall_nodesin that method are actually configurable.configurable_nodesmethod was only used in theConfigSelectorMethod, so this change renders the method unused so we can remove it.Checklist