Skip to content

Conversation

@trouze
Copy link
Contributor

@trouze trouze commented May 16, 2025

Resolves #11607

Problem

Today, our ConfigSelectorMethod supports selection from parsed and source nodes only.

As an example, you can do this dbt ls -s config.meta.contains_pii:true, but this command won't return any semantic layer saved queries that have this meta key in the config, despite us using configs for other purposes (as documented).

Solution

This PR changes the nodes used by the ConfigSelectorMethod to use all_nodes method instead of configurable_nodes. It's the case that all_nodes in that method are actually configurable.

configurable_nodes method was only used in the ConfigSelectorMethod, so this change renders the method unused so we can remove it.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@trouze trouze self-assigned this May 16, 2025
@cla-bot cla-bot bot added the cla:yes label May 16, 2025
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.93%. Comparing base (f1106ad) to head (3b12a36).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11635      +/-   ##
==========================================
- Coverage   91.90%   89.93%   -1.98%     
==========================================
  Files         199      199              
  Lines       24363    24380      +17     
==========================================
- Hits        22390    21925     -465     
- Misses       1973     2455     +482     
Flag Coverage Δ
integration 86.18% <100.00%> (-2.66%) ⬇️
unit 65.29% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.29% <100.00%> (+0.03%) ⬆️
Integration Tests 86.18% <100.00%> (-2.66%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trouze trouze marked this pull request as ready for review June 27, 2025 14:42
@trouze trouze requested a review from a team as a code owner June 27, 2025 14:42
@github-actions github-actions bot added the community This PR is from a community member label Jun 27, 2025
@dosubot
Copy link

dosubot bot commented Aug 18, 2025

Related Documentation
0 document(s) may need updating based on files changed in this PR

How did I do? Any feedback?  Join Discord

@trouze trouze force-pushed the trouze/extend-config-selector-nodes branch from 3179d46 to 5d37b84 Compare August 18, 2025 21:05
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ This looks great! One thing though, we should add some tests! I think the most appropriate place would be to add them to tests/functional/selectors/

@trouze
Copy link
Contributor Author

trouze commented Aug 21, 2025

@QMalcolm added some unit & functional tests!

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes community This PR is from a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Extend Eligible Nodes for ConfigSelectorMethod to include Saved Query Nodes

3 participants