feat(imageio-openjpeg): enable raster read on OpenJp2ImageReader
#332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class now overrides the raster functions from `ImageReader` class. The `canReadRaster` returns true enabling the caller to call `readRaster` and `readTileRaster`. The readRaster and readTileRaster call the normal read functions and then return the raster with `getData` call on the buffered image. Test cases are added to compare the rasters on expected and actual images with the option of tolerance in the diff of samples if the quality of images is low.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class now overrides the raster functions from
ImageReaderclass. ThecanReadRasterreturns true enabling the caller to callreadRasterandreadTileRaster.The readRaster and readTileRaster call the normal read functions and then return the raster with
getDatacall on the buffered image.Test cases are added to compare the rasters on expected and actual images with the option of tolerance in the diff of samples if the quality of images is low.
I have made these changes based on the assumption that openjpeg supports rasters
Related issue: #244