Skip to content

Fix: Dead link and deprecation warnings #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2025
Merged

Fix: Dead link and deprecation warnings #1122

merged 4 commits into from
Apr 19, 2025

Conversation

Zoraiyo
Copy link
Contributor

@Zoraiyo Zoraiyo commented Apr 19, 2025

Summary

This PR addresses the following minor improvements:

  • Fixes a dead link to "Invoke – Getting Started" in how-to-contribute.md
  • Fixes a deprecation warning where Modal.backdropStyle incorrectly referenced to Modal.content_style instead of the correct Modal.backdrop_style
  • Uniform deprecation warning messages to ensure consistent formatting

@Zoraiyo Zoraiyo force-pushed the fix/wrong-link-and-deprecation-warning branch from 38f4574 to 187ec57 Compare April 19, 2025 12:45
tcbegley
tcbegley approved these changes Apr 19, 2025
View reviewed changes
Copy link
Collaborator

@tcbegley tcbegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for making these changes!

I pushed an additional commit because I realised that the "how to release" guide is actually out of date.

@tcbegley tcbegley enabled auto-merge (squash) April 19, 2025 13:44
@tcbegley tcbegley merged commit ff8ecab into dbc-team:main Apr 19, 2025
8 checks passed
@tcbegley tcbegley mentioned this pull request Apr 21, 2025
Merged
tcbegley added a commit that referenced this pull request Apr 21, 2025
@Zoraiyo @tcbegley
Fix: Dead link and deprecation warnings (#1122)
9c6df1a 
* Fix: Link and deprecation warning

* Update: uniform format for deprecation warnings

* Additional updates to release docs

* Lint / format

---------

Co-authored-by: tcbegley <tomcbegley@gmail.com>
@Zoraiyo Zoraiyo deleted the fix/wrong-link-and-deprecation-warning branch April 23, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcbegley tcbegley tcbegley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zoraiyo @tcbegley