Skip to content

Fix request #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix request #10

wants to merge 3 commits into from

Conversation

johnnoone
Copy link

No description provided.

davydovanton
davydovanton requested changes May 7, 2017
View reviewed changes
Copy link
Owner

@davydovanton davydovanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this PR.
Could you explain what (and why) you did here? (I found only new options method and unnecessary renaming attributes).

Thanks!

lib/rspec/hanami/request_helpers.rb
module RequestHelpers
class Request
def initialize(method, path, options)
def initialize(method, path, opts)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you rename this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davydovanton davydovanton davydovanton requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnnoone @davydovanton