change the Unicode string default char type to char32_t #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for the update :D |
davisking
pushed a commit
to kSkip/dlib
that referenced
this pull request
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: in some LLVM 19 based compiler (like emsdk v4.x), The base template for std::char_traits has been removed in LLVM 19. and the std::char_traits can only work with types other than char, wchar_t, char8_t, char16_t, char32_t. More discussion can be found in #3045
Validation:
1. dlib unit test build pass, cannot run full test with or without the changes.
2. emsdk 4.0.3 build pass