Skip to content

test: improve test reliability and ease of use #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Jun 14, 2025

This disables automatic filesystem-based test inclusion, opting for manual inclusion so the guides, which rely on additional features, can skip running unless all their required features are enabled.

This also wraps a few tests with Embed::run(...) as they may crash if the PHP environment is not fully set up. I think that is specific to ZTS builds as some things are not set up until the PHP bootstrap functions get called.

This disables automatic filesystem-based test inclusion, opting for
manual inclusion so the guides, which rely on additional features,
can skip running unless all their required features are enabled.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15650816286

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.105%

Totals Coverage Status
Change from base Build 15650590374: 0.0%
Covered Lines: 829
Relevant Lines: 3928

💛 - Coveralls

Copy link
Collaborator

@Xenira Xenira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to test this tomorrow, but looks good to me.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants