Skip to content

chore(macro)!: change rename defaults to match psr #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xenira
Copy link
Collaborator

@Xenira Xenira commented May 29, 2025

BREAKING CHANGE: Methods and Properties are renamed to camelCase by default. Classes to PascalCase and constants to UPPER_CASE.

Refs: #189

@Xenira Xenira linked an issue May 29, 2025 that may be closed by this pull request
@Xenira Xenira force-pushed the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch from e9e5d1f to a6d076e Compare May 29, 2025 19:22
@coveralls
Copy link

coveralls commented May 29, 2025

Pull Request Test Coverage Report for Build 15425510964

Details

  • 16 of 35 (45.71%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 20.885%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/macros/src/parsing.rs 16 18 88.89%
crates/macros/src/constant.rs 0 3 0.0%
crates/macros/src/function.rs 0 3 0.0%
crates/macros/src/class.rs 0 4 0.0%
crates/macros/src/impl_.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
crates/macros/src/constant.rs 1 0.0%
crates/macros/src/parsing.rs 1 89.66%
Totals Coverage Status
Change from base Build 15400471004: -0.04%
Covered Lines: 821
Relevant Lines: 3931

💛 - Coveralls

@joelwurtz
Copy link
Contributor

It seems php functions are also renamed to camelCase by default where it should be snake_case no ?

@Xenira
Copy link
Collaborator Author

Xenira commented Jun 3, 2025

@joelwurtz psr does not mention functions directly as far as I can tell. Seems both camel and snake case are possibilities here.

I like the idea of using snake here though.

@Xenira Xenira force-pushed the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch from a6d076e to 0309224 Compare June 3, 2025 18:55
BREAKING CHANGE: Methods and Properties are renamed to camelCase by default. Classes to PascalCase and constants to UPPER_CASE.

Refs: #189
@Xenira Xenira force-pushed the 189-prop-attribute-should-rename-fields-to-camelcase-by-default branch from 0309224 to 77214e4 Compare June 3, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[prop] attribute should rename fields to camelCase by default
3 participants