Skip to content

chore(ci): simplify ci, test all features combination #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

joelwurtz
Copy link
Contributor

THis should resolve #397 and certainly other things

  • removed the specific embed / zts images
  • test on thread safe for macos / linux env

I added cargo hack (and an alias to config) to make the test in CI check that everything works given all possible combinations of features. Also runnable in local (if you have cargo hack) by doing : cargo ci-test

@joelwurtz
Copy link
Contributor Author

I'm wondering if it's necessary to test both in stable and nightly (lot of variations) ? Maybe only testing php8.4 + nts + nightly is enough ?

@joelwurtz joelwurtz force-pushed the feat/ci-matrix branch 3 times, most recently from debd466 to 4fd40a3 Compare March 21, 2025 10:22
@joelwurtz joelwurtz force-pushed the feat/ci-matrix branch 3 times, most recently from 1027fa5 to f35207c Compare March 21, 2025 11:10
@Xenira
Copy link
Collaborator

Xenira commented Mar 22, 2025

@joelwurtz unstable has pointed out some problems in the past and I would like to keep it for that reason. Maybe move it to a nightly pipeline though.

Regarding the amount of variations, we should test all supported versions.
I'd like to reduce it as well, and things like 8.0 which is EOL could reduce it a little. I personally would like to drop it but till then I don't see much of a way to reduce it.

While CI takes a little time it is still reasonable and Id rather have more than too few checks.

@joelwurtz
Copy link
Contributor Author

Would having unstable only on one version (like done actually) would be enough ? Or should we do it on all versions ?

Also don't know why it does not work on windows, i can reproduce the problem on my windows system but it's only when clang > 15 (when using clang 15 it works) but looking at the script in CI it does not seems to install clang 15 actually so i don't know why it works ?

@Xenira
Copy link
Collaborator

Xenira commented Mar 22, 2025

Would having unstable only on one version (like done actually) would be enough ? Or should we do it on all versions ?

At least for windows we need all unstable, as stable is not supported afaik. On all others I would be fine with one unstable but full test on a nightly build.

Also don't know why it does not work on windows, i can reproduce the problem on my windows system but it's only when clang > 15 (when using clang 15 it works) but looking at the script in CI it does not seems to install clang 15 actually so i don't know why it works ?

I don't have windows. So prob not much help there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run embedded tests for all supported php versions
2 participants