-
Notifications
You must be signed in to change notification settings - Fork 73
chore(ci): simplify ci, test all features combination #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d29f457
to
a66fc3f
Compare
I'm wondering if it's necessary to test both in stable and nightly (lot of variations) ? Maybe only testing php8.4 + nts + nightly is enough ? |
debd466
to
4fd40a3
Compare
4fd40a3
to
27a8f3d
Compare
1027fa5
to
f35207c
Compare
55de784
to
f72da9c
Compare
23af5cf
to
9c27c64
Compare
1fc5305
to
f3c90ec
Compare
c3b495d
to
f292a41
Compare
@joelwurtz unstable has pointed out some problems in the past and I would like to keep it for that reason. Maybe move it to a nightly pipeline though. Regarding the amount of variations, we should test all supported versions. While CI takes a little time it is still reasonable and Id rather have more than too few checks. |
Would having unstable only on one version (like done actually) would be enough ? Or should we do it on all versions ? Also don't know why it does not work on windows, i can reproduce the problem on my windows system but it's only when clang > 15 (when using clang 15 it works) but looking at the script in CI it does not seems to install clang 15 actually so i don't know why it works ? |
At least for windows we need all unstable, as stable is not supported afaik. On all others I would be fine with one unstable but full test on a nightly build.
I don't have windows. So prob not much help there. |
caf6ec2
to
685f6eb
Compare
THis should resolve #397 and certainly other things
I added cargo hack (and an alias to config) to make the test in CI check that everything works given all possible combinations of features. Also runnable in local (if you have cargo hack) by doing :
cargo ci-test