-
Notifications
You must be signed in to change notification settings - Fork 3
171 upgrade tf 2190 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
171 upgrade tf 2190 #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment temporarily disable time-consuming workflows. Comment out BERT based text classification workflow possibly permanently, as this is obsolete.
Add branch to workflow.
Added a baseline fine tuning of the full GPT2 to compare against Cerebros text classifier.
Forgot to add dropout.
Amendments to Cerebros model.
Reduce seq length to accelerate job completion.
Up timeout to 300 min.
Correct history indexing error.
Temporary test to fast forward to cerebros model.
Comment out an artifact of GPT test so we this can lint and run.
Fix errors from trying to work too fast ...
Re-corrected the metrics BinaryAccuracy to correct AI introduced error.
Correct metric to rank by (binary accuracy) ...
Uncomment out GPT test ...
Upped number of trials to 5.
Make seq len 750, fix typo.
Try 1024 seq len.
Added branch to the workflow...
Added a positional embedding and a LayerNorm to the text embedding.
Missed position embedding in copy and paste ...
Synchronize embedding dim across embeddings.
Corrected import of PositionEmbedding.
Remove layernorm, concat instead of add.
Try addition to merge embeddings without LayerNorm
Restore optimal run with position embedding. Reduce max levels to fit the optimal run and reduce overhead. Test this to see if it works. if successful, add back the commented out comparison and PR. Then open an issue to optimize the params around this new model. We may need to run this on Katib to optimize the hyperparameters, as the model is fundamentally different than the original and can probably be optimized considerably.
Hard set levels to the known optimum.
Corrected hard set on levels to correct optima.
Restore the best model yet.
Add back the CICD test for image CLS. Prepare for PR.
Added back baseline workflow in best trial thus far.
Added all CICD tests to be used back to best NLP configuration.
Upgrade tf
Upgrade tensorflow-text to v 2.19.0
Add branch to workflows.
Typo on requirements.txt
Test to fast forward to Cerebros NLP test and check for compatibility.
Attempt to correct issue with tf v 2.19.0 graph scope.
Another attempt to resolve tf v 2.19.0 graph scope compatibility...
Run a full CICD run.
AI suggested tf 2.15.0 -> 2.19.0 compat fix.
Add back the baseline GPT2 task.
Fix a typo in string termination ...
Closed
Uncommented out CICD test that was left commented out by error.
All checks have passed on this version of the code:
|
Looks great, and I approve. |
Aidyn-Lopez
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and I approve.
This was referenced Apr 12, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Benchmarks: