Update network-services-operator with multicluster support, migrate e2e tests to Chainsaw #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anage resources from many control planes. A Datum provider is introduced that discovers Datum Projects and registers them as clusters. This will eventually be moved out into a shared library. Ginkgo test scaffolding has been removed, as we'll be leveraging Chainsaw. Existing tests will be ported in a future iteration. These changes depend on kubernetes-sigs/multicluster-runtime#17, as well as other changes to support kind clusters that do not have a prefix of "fleet-" in the name that have not yet been published.
…ster name, fixed bug in Datum provider.
scotwells
previously approved these changes
Mar 14, 2025
…nd added CRD documentation generated via 'make api-docs'
scotwells
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multicluster support
This PR introduces the use of the (currently experimental) multicluster-runtime library that brings the ability to attach an operator to multiple clusters with minimal changes to reconciler code. A new
cluster-discovery-modeflag has been introduced, and supports the following options:kindlibrary to discover kind clusters, and engage each one. I expect this to be useful in e2e tests as we move forward.Projectresources in the API server that the default kubeconfig interacts with, and engages a cluster for eachProjectfound. Currently it is expected that the project control plane is available via the path/apis/resourcemanager.datumapis.com/v1alpha/projects/{project_name}/control-planeon the same host that the main kubeconfig attaches to.An initial implementation of a multicluster-runtime
Providerfor Datum which watchesProjectresources is included in this PR. As that library stabilizes, we'll move it out to another location that other Datum operators can use.Note
The multicluster-runtime dependency is currently referencing a fork. As changes are merged
in to multicluster-runtime, such as kubernetes-sigs/multicluster-runtime#18, the dependency on the fork will be removed.
End to end tests
End to end tests have been replaced with Chainsaw. I referenced the opentelemetry-operator project's use of chainsaw in the Makefile and GitHub action changes.