Skip to content

Conversation

@baltpeter
Copy link
Member

@baltpeter baltpeter commented Oct 25, 2025

This should be squashed when merging.

This release brings various useful new esbuild features.
@cypress
Copy link

cypress bot commented Oct 25, 2025

datenanfragen/website    Run #8425

Run Properties:  status check failed Failed #8425  •  git commit 95253875bb: Webpack be gone \o/
Project datenanfragen/website
Branch Review b_hugo-esbuild
Run status status check failed Failed #8425
Run duration 18m 02s
Commit git commit 95253875bb: Webpack be gone \o/
Committer Benjamin Altpeter
View all properties for this run ↗︎

Test results
Tests that failed  Failures 16
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 8
Tests that did not run due to a failure in a mocha hook  Skipped 1
Tests that passed  Passing 63
View all changes introduced in this branch ↗︎

Tests for review

Failed  company-database/search.spec.js • 1 failed test

View Output Video

Test Artifacts
Search for company by slug and visit company detail page > Search for and visit 1&1 single page Screenshots Video
Failed  components/advanced-generator.spec.js • 3 failed tests

View Output Video

Test Artifacts
Advanced generator > reflects 'Get data in a machine-readable format' checkbox in the generated request [true] Screenshots Video
Advanced generator > reflects the 'Information block' values in the generated request Screenshots Video
Advanced generator > changes the text based on the 'Erase all data' checkbox and the 'Data to erase' field when 'Erasure request' is selected Screenshots Video
Failed  components/generator.spec.js • 2 failed tests

View Output Video

Test Artifacts
Request generator tool component > respects request tracking status Screenshots Video
Request generator tool component > can toggle request tracking status Screenshots Video
Failed  components/mailto-dropdown.spec.js • 1 failed test

View Output Video

Test Artifacts
MailtoDropdown > Copying the email elements manually Screenshots Video
Failed  components/proceedings.spec.js • 1 failed test

View Output Video

Test Artifacts
Proceedings page > assigns correct state Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

@baltpeter baltpeter changed the base branch from master to webpack-node-staging November 3, 2025 14:32
@baltpeter
Copy link
Member Author

Alright. As far as I can tell, this is now ready for review. A couple of things to note:

  • This should be reviewed very carefully. There is obviously quite a lot of potential for breakage. In addition to that, we also need to be on the look-out for non-obvious gotchas like https://github.com/datenanfragen/website/blob/b_hugo-esbuild/layouts/partials/scripts.html#L10-L11. I would appreciate a review from both of you, @zner0L and @mal-tee.

  • As we discussed in Build JS with Hugo instead of Webpack #1211 (comment), I have been ignoring CI failures because of interdependencies between this PR and node 22 #1205, where neither can really move forward without the other. The random build failures I've been seeing (both locally and in CI) seem like a Hugo bug (locally, I've been using the latest Hugo version today and not seen it happen anymore so far), but because of our ancient Node version and which Docker images are available for it, we cannot upgrade Hugo yet.

    As such, I propose that we merge this PR into the webpack-node-staging branch for the time being. Then @davenewham can rebase node 22 #1205 onto that, which should hopefully simplify that PR greatly. We'd then also merge node 22 #1205 into webpack-node-staging. And finally, I would work on webpack-node-staging and fix the final remaining issues and create a PR to merge that into master.

  • Given the previous point, I also haven't fixed all Cypress errors yet. There are a handful when I run the tests locally, but at a glance these all seem like Cypress flake to me. Thus, I don't think it makes sense to work on them before we've updated everything.

@baltpeter baltpeter marked this pull request as ready for review November 3, 2025 14:42
@mal-tee
Copy link
Member

mal-tee commented Nov 3, 2025

We can also bump cypress after the node bump, which will introduce some QoL features iirc :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants