Skip to content

Add NewareNDA extractor #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Add NewareNDA extractor #29

merged 3 commits into from
May 20, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 16, 2025

An extractor library for the neware-nda format (reused the same ID... think this is fine?)

Copy link
Member Author

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Development has now moved out to a personal fork, so we should probably use that.

Copy link
Contributor

@PeterKraus PeterKraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the CI fails, but once it passes, LGTM.

Edit: So it is the trailing space. How does that not get linted away?

@ml-evs
Copy link
Member Author

ml-evs commented May 20, 2025

Not sure why the CI fails, but once it passes, LGTM.

Edit: So it is the trailing space. How does that not get linted away?

Should work now after #31, but we don't have auto-linting turned on

@ml-evs ml-evs force-pushed the ml-evs/add-neware-nda branch from 8ba1a09 to b999ebc Compare May 20, 2025 09:33
@ml-evs ml-evs merged commit bf6a7f2 into main May 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants