Skip to content

Conversation

mneilson-usgs
Copy link
Contributor

Remove scale argument from plotRGB() calls, as this argument currently is misleading (should not be larger than max value of bands within the raster).

Closes #476

Copy link

github-actions bot commented Aug 8, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-490

The following changes were observed in the rendered markdown documents:

 05-raster-multi-band-in-r.md                           |  10 ++--------
 ...and-in-r-rendered-plot-rbg-image-linear-1.png (new) | Bin 0 -> 466193 bytes
 ...-band-in-r-rendered-plot-rgb-image-hist-1.png (new) | Bin 0 -> 519899 bytes
 md5sum.txt                                             |   2 +-
 4 files changed, 3 insertions(+), 9 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-08-08 21:08:22 +0000

github-actions bot pushed a commit that referenced this pull request Aug 8, 2025
@jonjab
Copy link
Contributor

jonjab commented Aug 12, 2025

Thanks for the explanation. We knew it didn't do anything, and weren't even sure why one would want to do this.

@jonjab jonjab merged commit c99bee2 into datacarpentry:main Aug 12, 2025
3 checks passed
@mneilson-usgs mneilson-usgs deleted the ep_5_fix branch August 12, 2025 15:54
github-actions bot pushed a commit that referenced this pull request Aug 12, 2025
Auto-generated via `{sandpaper}`
Source  : c99bee2
Branch  : main
Author  : Jon Jablonski <jonjab@ucsb.edu>
Time    : 2025-08-12 15:51:30 +0000
Message : Merge pull request #490 from mneilson-usgs/ep_5_fix

Fix plotRGB errors in Ep. 5
github-actions bot pushed a commit that referenced this pull request Aug 12, 2025
Auto-generated via `{sandpaper}`
Source  : e5ed56f
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-08-12 15:55:45 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c99bee2
Branch  : main
Author  : Jon Jablonski <jonjab@ucsb.edu>
Time    : 2025-08-12 15:51:30 +0000
Message : Merge pull request #490 from mneilson-usgs/ep_5_fix

Fix plotRGB errors in Ep. 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ep 5: Plotting stretched color raster erroring in lesson

2 participants