-
-
Notifications
You must be signed in to change notification settings - Fork 125
Update setup instructions #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-342 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-05-07 13:27:50 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tobyhodges - looks good! I tried this out on my Windows laptop, and all worked well 😄 I left a few comments below.
@datacarpentry/image-processing-curriculum-maintainers - it would be great if you could try this out too, especially if you're on mac/linux
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks @tobyhodges ! I'll leave this open for a while longer, in case the other maintainers have any input
@datacarpentry/image-processing-curriculum-maintainers - do feel free to add any further comments / suggestions, otherwise I'll merge this PR at the end of this week |
learners/setup.md
Outdated
opposed to the one with Python 2). If you wish to use an existing | ||
installation, be sure to upgrade your scikit-image to at least 0.19. | ||
You can upgrade to the latest scikit-image using the shell command that follows. | ||
1. Download and install the latest [MiniForge distribution of Python](https://conda-forge.org/download/) for your operating system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's obvious that, on Unix-like platforms, you need to run
bash Miniforge3-$(uname)-$(uname -m).sh
from the terminal to install Miniforge... I would add a line about this. Is it obvious on Windows? I guess so, if you need to double-click what you just downloaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - on Windows it's an .exe
file, so you just double-click the downloaded file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a link to the central instructions, which are more detailed, in 9c8345e.
I just tried on Linux x86_64, I downloaded the $ mv ~/Downloads/environment.yml .
$ conda env create -f environment.yml
Solving environment: failed
CondaValueError: Malformed version string '~': invalid character(s).
$ cat environment.yml
name: dc-image
channels:
- conda-forge
dependencies:
- python>=3.11
- jupyterlab
- numpy
- matplotlib
- scikit-image
- ipympl
- imageio I tried editing the file by removing the Python version, but got the same error. 🤔 |
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
@mkcor is it possible that your conda version needs to be updated? |
Oh, yes, most likely: $ conda --version
conda 4.5.11 Thanks, @tobyhodges!
And I'm getting the same error when I try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could follow the setup instructions successfully! 🎉
I have installed a fresh version (25.3.0) of conda
via Miniforge and I'm running Debian GNU/Linux 12 (bookworm).
Thanks all for the input! @tobyhodges feel free to merge when you're ready - if you could update the FigShare with the new environment file at the same time - that would be great 😄 |
I have published a new version of the data on FigShare and will merge this now. |
Auto-generated via `{sandpaper}` Source : ff65c23 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2025-05-19 12:07:11 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 7597b4b Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2025-05-19 12:06:25 +0000 Message : Merge pull request #342 from datacarpentry/update-python-setup Update setup instructions
Auto-generated via `{sandpaper}` Source : ff65c23 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2025-05-19 12:07:11 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 7597b4b Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2025-05-19 12:06:25 +0000 Message : Merge pull request #342 from datacarpentry/update-python-setup Update setup instructions
This updates the setup instructions for Python workshops. A recent blog post provides more context for this change. Specifically, this PR updates the instructions to reflect that we recommend Miniforge instead of Anaconda Python.
One of the most important changes here is to include an
environment.yml
for learners to use to create an environment that they can work in during the workshop/while following the lesson. When this PR is ready to merge, I will release a new version of the example data on FigShare that contains the environment file. Since I guess it will be helpful for testing purposes -- and because it is probably a good idea to keep a copy in the lesson repo too -- you can find my proposed version of that file in this PR.