Skip to content

Exclude TACL migration in table migration integration tests #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

JCZuurmond
Copy link
Contributor

@JCZuurmond JCZuurmond commented Dec 13, 2024

Changes

Exclude TACL migration in table migration integration tests because these were not asserted, and to speed up the tests and reduce flakiness

Linked issues

Attempt to reduce flakiness blocking CI in #3239
Similar to #3437 in the sense that both PR scope integration tests to a smaller set of resources

Tests

  • modified integration tests

@JCZuurmond JCZuurmond added integration test failure internal this pull request won't appear in release notes labels Dec 13, 2024
@JCZuurmond JCZuurmond self-assigned this Dec 13, 2024
@JCZuurmond JCZuurmond requested a review from a team as a code owner December 13, 2024 08:46
@JCZuurmond JCZuurmond force-pushed the fix/limit-migrate-tables-worklfows branch from c3485dc to 096388b Compare December 13, 2024 08:48
Copy link

github-actions bot commented Dec 13, 2024

✅ 55/55 passed, 1 flaky, 4 skipped, 1h46m13s total

Flaky tests:

  • 🤪 test_create_all_catalogs_schemas (8.034s)

Running from acceptance #7737

Copy link
Contributor

@FastLee FastLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good Job.

@JCZuurmond JCZuurmond added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit ba5872f Dec 13, 2024
7 checks passed
@JCZuurmond JCZuurmond deleted the fix/limit-migrate-tables-worklfows branch December 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal this pull request won't appear in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants