-
Notifications
You must be signed in to change notification settings - Fork 96
Add UCX history schema and table for storing UCX's artifact #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
4b05cf0
Add history record
JCZuurmond f9cbc17
Add history install
JCZuurmond f507b12
Fix type hint
JCZuurmond 3b9b279
Update history record dataclass
JCZuurmond 285429d
Add `run_as` attribute to `HistoricalRecord`
JCZuurmond 2ce2b2d
Add default to `HistoricalRecord.object_type_version`
JCZuurmond 4622570
Sort `HistoricalRecord attributes`
JCZuurmond 642a700
Add `ucx_version` to `HistoryRecord`
JCZuurmond 61aec4d
Rename object_owner to owner
JCZuurmond 96d8117
Ignore too many attributes on dataclass
JCZuurmond 7c9b670
Use consistent attribute docs
JCZuurmond f773878
Check if the historical records are populated
JCZuurmond bf011d9
Set UCX version by default
JCZuurmond 23125ff
Rephrase to `job_run_id`
JCZuurmond bf7ae1f
Remove fields part of WorkflowRun
JCZuurmond e5705ac
Make snapshot id None by default
JCZuurmond 4b2cd0b
Do not check for history records yet
JCZuurmond d2556a5
Test for historical records table to be created
JCZuurmond 0d5f34a
Change object_data to data
JCZuurmond e2610f6
Move failures down
JCZuurmond 01d1a71
Make snapshot id an string
JCZuurmond 70702f0
Rename HistoricalRecord to Historical
JCZuurmond 1abf804
Remove snapshot_id and object_version
JCZuurmond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
def test_progress_tracking_installer_creates_workflow_runs_table(az_cli_ctx) -> None: | ||
import pytest | ||
|
||
|
||
@pytest.mark.parametrize("table_name", ["workflow_runs", "historical"]) | ||
def test_progress_tracking_installer_creates_table(az_cli_ctx, table_name) -> None: | ||
az_cli_ctx.progress_tracking_installation.run() | ||
query = ( | ||
f"SELECT 1 FROM tables WHERE table_catalog = '{az_cli_ctx.config.ucx_catalog}' " | ||
"AND table_schema = 'multiworkspace' AND table_name = 'workflow_runs'" | ||
f"AND table_schema = 'multiworkspace' AND table_name = '{table_name}'" | ||
) | ||
assert any(az_cli_ctx.sql_backend.fetch(query, catalog="system", schema="information_schema")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.