Skip to content

Fix uvicorn command in custom-server README #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

zaxier
Copy link
Contributor

@zaxier zaxier commented Jun 18, 2025

The command had two issues:

  1. Used 'custom-server' instead of 'custom_server' (Python modules use underscores)
  2. Referenced ':mcp' instead of ':app' (the FastAPI instance is named 'app')

🤖 Generated with Claude Code

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

README update.

How is this PR tested?

Only README.md is changed

Does this PR require documentation update?

No. The PR is itself a documentation update.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes.
    Fixed bug in custom-server README.

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

The command had two issues:
1. Used 'custom-server' instead of 'custom_server' (Python modules use underscores)
2. Referenced ':mcp' instead of ':app' (the FastAPI instance is named 'app')

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@renardeinside renardeinside merged commit 90c6677 into databrickslabs:master Jun 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants