-
Notifications
You must be signed in to change notification settings - Fork 77
Add Local Dashboard Manager for Profilers #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ 46/46 passed, 7 flaky, 3m15s total Flaky tests:
Running from acceptance #2808 |
src/databricks/labs/lakebridge/assessments/dashboards/dashboard_manager.py
Outdated
Show resolved
Hide resolved
| logging.basicConfig(level=logging.INFO) | ||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a Comment to say why we are deviating from LSQL deployment, so other reviewers don't block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we deviating from LSQL for local dashboards?
LSQL has the following limitations:
- doesn't scale well to the many source EDWs Lakebridge will support
- limited support for visualization types beyond table, bar chart, and counter
- steep learning curve for future maintainers
Instead, we've adopted a dashboard template approach which can easily be mainained, easy to learn, serializable, and can be interpolated with the catalog and schema values.
src/databricks/labs/lakebridge/assessments/dashboards/dashboard_manager.py
Show resolved
Hide resolved
| def __init__(self, ws: WorkspaceClient, current_user: User, is_debug: bool = False): | ||
| self._ws = ws | ||
| self._current_user = current_user | ||
| self._dashboard_location = f"/Workspace/Users/{self._current_user}/Lakebridge/Dashboards" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rely on the blueprint to save the file workspace. It should be inside the .lakebridge folder
2dcdf50 to
25c1724
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
- Coverage 64.92% 64.70% -0.22%
==========================================
Files 96 97 +1
Lines 7908 7971 +63
Branches 822 825 +3
==========================================
+ Hits 5134 5158 +24
- Misses 2595 2634 +39
Partials 179 179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes
What does this PR do?
Relevant implementation details
Caveats/things to watch out for when reviewing:
Linked issues
Functionality
databricks labs lakebridge ...Tests