-
Notifications
You must be signed in to change notification settings - Fork 15
map_chunked
implementation
#99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lorenzorubi-db
wants to merge
3
commits into
databrickslabs:master
Choose a base branch
from
lorenzorubi-db:map_chunked-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,7 +1,8 @@ | ||||||
import concurrent.futures | ||||||
import copy | ||||||
import re | ||||||
from typing import Optional, List | ||||||
import more_itertools | ||||||
from typing import Optional, List, Callable | ||||||
from discoverx import logging | ||||||
from discoverx.common import helper | ||||||
from discoverx.discovery import Discovery | ||||||
|
@@ -165,7 +166,7 @@ def scan( | |||||
discover.scan(rules=rules, sample_size=sample_size, what_if=what_if) | ||||||
return discover | ||||||
|
||||||
def map(self, f) -> list[any]: | ||||||
def map(self, f: Callable) -> list[any]: | ||||||
"""Runs a function for each table in the data explorer | ||||||
|
||||||
Args: | ||||||
|
@@ -197,6 +198,39 @@ def map(self, f) -> list[any]: | |||||
|
||||||
return res | ||||||
|
||||||
def map_chunked(self, f: Callable, tables_per_chunk: int, **kwargs) -> list[any]: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
any is a function, not a type |
||||||
"""Runs a function for each table in the data explorer | ||||||
|
||||||
Args: | ||||||
f (function): The function to run. The function should accept either a list of TableInfo objects as input and return a list of any object as output. | ||||||
|
||||||
Returns: | ||||||
list[any]: A list of the results of running the function for each table | ||||||
""" | ||||||
res = [] | ||||||
table_list = self._info_fetcher.get_tables_info( | ||||||
self._catalogs, | ||||||
self._schemas, | ||||||
self._tables, | ||||||
self._having_columns, | ||||||
self._with_tags, | ||||||
) | ||||||
with concurrent.futures.ThreadPoolExecutor(max_workers=self._max_concurrency) as executor: | ||||||
# Submit tasks to the thread pool | ||||||
futures = [ | ||||||
executor.submit(f, table_chunk, **kwargs) for table_chunk in more_itertools.chunked(table_list, tables_per_chunk) | ||||||
] | ||||||
|
||||||
# Process completed tasks | ||||||
for future in concurrent.futures.as_completed(futures): | ||||||
result = future.result() | ||||||
if result is not None: | ||||||
res.extend(result) | ||||||
|
||||||
logger.debug("Finished lakehouse map_chunked task") | ||||||
|
||||||
return res | ||||||
|
||||||
|
||||||
class DataExplorerActions: | ||||||
def __init__( | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,7 @@ | |
"delta-spark>=2.2.0", | ||
"pandas<2.0.0", # From 2.0.0 onwards, pandas does not support iteritems() anymore, spark.createDataFrame will fail | ||
"numpy<1.24", # From 1.24 onwards, module 'numpy' has no attribute 'bool'. | ||
"more_itertools", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Create LPP ticket for this, otherwise re-implement a single function. Don't add whole library for the sake of a function |
||
] | ||
|
||
TEST_REQUIREMENTS = [ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.