Skip to content

bugfix: stalling test issue (close in TelemetryClientFactory) #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 23, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/databricks/sql/telemetry/telemetry_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,8 @@ class TelemetryClientFactory:
] = {} # Map of session_id_hex -> BaseTelemetryClient
_executor: Optional[ThreadPoolExecutor] = None
_initialized: bool = False
_lock = threading.Lock() # Thread safety for factory operations
_lock = threading.RLock() # Thread safety for factory operations
# used RLock instead of Lock to avoid deadlocks when garbage collection is triggered
_original_excepthook = None
_excepthook_installed = False

Expand Down
Loading