Skip to content

Remove non-actionable warning messages in error construction. #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Remove non-actionable warning messages in error construction. #970

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8812096
Remove unnecessary warnings
renaudhartert-db May 15, 2025
9f69db9
Remove warning
renaudhartert-db May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 9 additions & 30 deletions databricks/sdk/errors/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,31 +62,6 @@ def __init__(
:param details:
:param kwargs:
"""
# SCIM-specific parameters are deprecated.
if detail:
warnings.warn(
"The 'detail' parameter of DatabricksError is deprecated and will be removed in a future version."
)
if scimType:
warnings.warn(
"The 'scimType' parameter of DatabricksError is deprecated and will be removed in a future version."
)
if status:
warnings.warn(
"The 'status' parameter of DatabricksError is deprecated and will be removed in a future version."
)

# API 1.2-specific parameters are deprecated.
if error:
warnings.warn(
"The 'error' parameter of DatabricksError is deprecated and will be removed in a future version."
)

# Retry-after is deprecated.
if retry_after_secs:
warnings.warn(
"The 'retry_after_secs' parameter of DatabricksError is deprecated and will be removed in a future version."
)

if detail:
# Handle SCIM error message details
Expand All @@ -101,7 +76,7 @@ def __init__(

super().__init__(message if message else error)
self.error_code = error_code
self.retry_after_secs = retry_after_secs
self._retry_after_secs = retry_after_secs
self._error_details = errdetails.parse_error_details(details or [])
self.kwargs = kwargs

Expand All @@ -113,13 +88,17 @@ def __init__(
continue
self.details.append(ErrorDetail.from_dict(d))

def get_error_info(self) -> List[ErrorDetail]:
return self._get_details_by_type(errdetails._ERROR_INFO_TYPE)
@property
def retry_after_secs(self) -> Optional[int]:
warnings.warn(
"The 'retry_after_secs' parameter of DatabricksError is deprecated and will be removed in a future version."
)
return self._retry_after_secs

def _get_details_by_type(self, error_type) -> List[ErrorDetail]:
def get_error_info(self) -> List[ErrorDetail]:
if self.details is None:
return []
return [detail for detail in self.details if detail.type == error_type]
return [detail for detail in self.details if detail.type == errdetails._ERROR_INFO_TYPE]

def get_error_details(self) -> errdetails.ErrorDetails:
return self._error_details
Expand Down
Loading