Skip to content

[Internal] Make model serving unit tests a little more hermetic #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

renaudhartert-db
Copy link
Contributor

@renaudhartert-db renaudhartert-db commented Feb 28, 2025

What changes are proposed in this pull request?

This PR is a no-op that makes the model serving unit tests a little more hermetic. The solution is not perfect and we will have to consider better ways to enable hermetic tests in the future (which might involve a refactoring of the Config object in SDK-Mod).

How is this tested?

N/A

NO_CHANGELOG=true

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 906
  • Commit SHA: 2c62fdb25a1e61e20492986cd9045a3ec9de0734

Checks will be approved automatically on success.

@renaudhartert-db renaudhartert-db added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit f4db6f4 Feb 28, 2025
18 checks passed
@renaudhartert-db renaudhartert-db deleted the renaud.hartert/test-isolation branch February 28, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants