-
Notifications
You must be signed in to change notification settings - Fork 154
[Feature] Large file uploads (901) #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
renaudhartert-db
merged 15 commits into
databricks:main
from
ksafonov-db:implement-incremental-uploads
Mar 5, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3fcee3b
[901] Large file uploads
ksafonov-db 17e388b
Fix warning
ksafonov-db e86a56e
Restore Python 3.8 compatibility (where `builtins.type` does not supp…
ksafonov-db b8fde0a
Merge remote-tracking branch 'upstream' into implement-incremental-up…
ksafonov-db 5cf738d
Reformat
ksafonov-db a146db2
Cleanup after merge, add some docs
ksafonov-db 8c97a49
Followups
ksafonov-db f1f3e26
Improve retry logic, add more test cases and comments
ksafonov-db e82e5f8
Merge remote-tracking branch 'upstream' into implement-incremental-up…
ksafonov-db a320c69
Add integration test for the new Files API client
ksafonov-db 198b3b1
Merge branch 'main' into implement-incremental-uploads
renaudhartert-db 6679798
Cleanup / address review comments
ksafonov-db fbf7ccd
Merge branch 'main' into implement-incremental-uploads
renaudhartert-db 731a3b7
Reformat
ksafonov-db b4d39cc
Remove new test
ksafonov-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As defined, these are static variables that would be shared by all instance of the
Config
class. My understanding is that these should be considered as static constants. If so, let's rename rename them in uppercase to make that clear.If the intent is to make them actual instance variable, then these should be defined in the
init
function: