[Internal] Implement async token refresh #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/stale-token
branch
from
949fd00 to
51b9228
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/stale-token
branch
from
bc69e43 to
fb1a50f
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/stale-token
branch
from
fb1a50f to
6ba0e52
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
reviewed
Feb 20, 2025
hectorcast-db
force-pushed
the
hectorcast-db/stale-token
branch
from
6ba0e52 to
cdcbf27
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/stale-token
branch
from
cdcbf27 to
11c42a2
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
reviewed
Feb 21, 2025
databricks/sdk/oauth.py
Outdated
Comment on lines
248
to
250
| token_state = self._token_state() | ||
|
|
||
| with self._lock: | ||
| token = self._token |
There was a problem hiding this comment.
Because we release the lock here, the token on line 251 could be different than the one used in _token_state(). If we convert _token_state() to something that returns the token and its state, we can avoid that problem. Thoughts?
databricks/sdk/oauth.py
Outdated
| self._is_refreshing = False | ||
|
|
||
| with self._lock: | ||
| if not self._is_refreshing and not self._refresh_err: |
There was a problem hiding this comment.
I think this is safe but might fetch more tokens than necessary. Like you mentioned offline, the first thread to acquire this lock will start the refresh process, and then all other threads that acquire the lock while refresh is happening will skip. However, once refresh is complete, other threads that acquire the lock (e.g. that checked that the token was stale and came down this pathway while the refresh was ongoing, then only acquired this lock after refresh was completed) will unnecessarily refresh the token again. So I think we should also check the token state again here: if it is not stale, skip the refresh.
hectorcast-db
force-pushed
the
hectorcast-db/stale-token
branch
from
11c42a2 to
21c999f
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
requested changes
Feb 21, 2025
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
approved these changes
Feb 21, 2025
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/stale-token
branch
from
c671d4c to
d3ffe79
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mgyucht
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR is a step towards enabling asynchronous refreshes of data plane tokens.
This PR updates the existing
Refreshableabstract token class to support async token refresh.Note: async refreshes are disabled at the moment and will be enabled in a follow-up PR.
How is this tested?
Added unit tests.
Changelog
The changelog entry will be added when the feature is enabled.
NO_CHANGELOG=true