Skip to content

Add new ErrHTMLContent value to represent errors due to HTML parsing. #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025

Conversation

renaudhartert-db
Copy link
Contributor

What changes are proposed in this pull request?

This PR adds a new error value ErrHTMLContent to differentiate parsing errors caused by HTML content from other parsing errors — which are likely to be due actual implementation issues within the SDK. The new error value can be used by higher-level tools (e.g. the Databricks CLI) to provide actionable feedback to users.

How is this tested?

Unit and integration tests.

Copy link
Contributor

@parthban-db parthban-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo clarification.

Comment on lines +372 to +374
statusCode: 200,
status: "OK",
errorMessage: httpclient.ErrHTMLContent.Error(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding, is this case even possible? Don't we have a single statuscode for this kind of error?

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1252
  • Commit SHA: e80221de8f7fbf38e8572b7bdb587b8537b4d341

Checks will be approved automatically on success.

@renaudhartert-db renaudhartert-db added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit d422ef0 Jul 24, 2025
15 checks passed
@renaudhartert-db renaudhartert-db deleted the renaud-hartert_data/html branch July 24, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants