Skip to content

Revert custom serialization #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apierr/error_overrides.go linguist-generated=true
error_alias.go linguist-generated=true
experimental/mocks/mock_account_client.go linguist-generated=true
experimental/mocks/mock_workspace_client.go linguist-generated=true
experimental/mocks/service/aibuilder/mock_ai_builder_interface.go linguist-generated=true
experimental/mocks/service/aibuilder/mock_custom_llms_interface.go linguist-generated=true
experimental/mocks/service/apps/mock_apps_interface.go linguist-generated=true
experimental/mocks/service/billing/mock_billable_usage_interface.go linguist-generated=true
Expand Down Expand Up @@ -81,6 +82,7 @@ experimental/mocks/service/marketplace/mock_provider_personalization_requests_in
experimental/mocks/service/marketplace/mock_provider_provider_analytics_dashboards_interface.go linguist-generated=true
experimental/mocks/service/marketplace/mock_provider_providers_interface.go linguist-generated=true
experimental/mocks/service/ml/mock_experiments_interface.go linguist-generated=true
experimental/mocks/service/ml/mock_feature_store_interface.go linguist-generated=true
experimental/mocks/service/ml/mock_forecasting_interface.go linguist-generated=true
experimental/mocks/service/ml/mock_model_registry_interface.go linguist-generated=true
experimental/mocks/service/oauth2/mock_account_federation_policy_interface.go linguist-generated=true
Expand Down Expand Up @@ -163,117 +165,94 @@ experimental/mocks/service/workspace/mock_workspace_interface.go linguist-genera
service/aibuilder/api.go linguist-generated=true
service/aibuilder/impl.go linguist-generated=true
service/aibuilder/interface.go linguist-generated=true
service/aibuilder/internal.go linguist-generated=true
service/aibuilder/model.go linguist-generated=true
service/apps/api.go linguist-generated=true
service/apps/impl.go linguist-generated=true
service/apps/interface.go linguist-generated=true
service/apps/internal.go linguist-generated=true
service/apps/model.go linguist-generated=true
service/billing/api.go linguist-generated=true
service/billing/impl.go linguist-generated=true
service/billing/interface.go linguist-generated=true
service/billing/internal.go linguist-generated=true
service/billing/model.go linguist-generated=true
service/catalog/api.go linguist-generated=true
service/catalog/impl.go linguist-generated=true
service/catalog/interface.go linguist-generated=true
service/catalog/internal.go linguist-generated=true
service/catalog/model.go linguist-generated=true
service/cleanrooms/api.go linguist-generated=true
service/cleanrooms/impl.go linguist-generated=true
service/cleanrooms/interface.go linguist-generated=true
service/cleanrooms/internal.go linguist-generated=true
service/cleanrooms/model.go linguist-generated=true
service/compute/api.go linguist-generated=true
service/compute/impl.go linguist-generated=true
service/compute/interface.go linguist-generated=true
service/compute/internal.go linguist-generated=true
service/compute/model.go linguist-generated=true
service/dashboards/api.go linguist-generated=true
service/dashboards/impl.go linguist-generated=true
service/dashboards/interface.go linguist-generated=true
service/dashboards/internal.go linguist-generated=true
service/dashboards/model.go linguist-generated=true
service/database/api.go linguist-generated=true
service/database/impl.go linguist-generated=true
service/database/interface.go linguist-generated=true
service/database/internal.go linguist-generated=true
service/database/model.go linguist-generated=true
service/files/api.go linguist-generated=true
service/files/impl.go linguist-generated=true
service/files/interface.go linguist-generated=true
service/files/internal.go linguist-generated=true
service/files/model.go linguist-generated=true
service/iam/api.go linguist-generated=true
service/iam/impl.go linguist-generated=true
service/iam/interface.go linguist-generated=true
service/iam/internal.go linguist-generated=true
service/iam/model.go linguist-generated=true
service/jobs/api.go linguist-generated=true
service/jobs/impl.go linguist-generated=true
service/jobs/interface.go linguist-generated=true
service/jobs/internal.go linguist-generated=true
service/jobs/model.go linguist-generated=true
service/marketplace/api.go linguist-generated=true
service/marketplace/impl.go linguist-generated=true
service/marketplace/interface.go linguist-generated=true
service/marketplace/internal.go linguist-generated=true
service/marketplace/model.go linguist-generated=true
service/ml/api.go linguist-generated=true
service/ml/impl.go linguist-generated=true
service/ml/interface.go linguist-generated=true
service/ml/internal.go linguist-generated=true
service/ml/model.go linguist-generated=true
service/oauth2/api.go linguist-generated=true
service/oauth2/impl.go linguist-generated=true
service/oauth2/interface.go linguist-generated=true
service/oauth2/internal.go linguist-generated=true
service/oauth2/model.go linguist-generated=true
service/pipelines/api.go linguist-generated=true
service/pipelines/impl.go linguist-generated=true
service/pipelines/interface.go linguist-generated=true
service/pipelines/internal.go linguist-generated=true
service/pipelines/model.go linguist-generated=true
service/pkg.go linguist-generated=true
service/provisioning/api.go linguist-generated=true
service/provisioning/impl.go linguist-generated=true
service/provisioning/interface.go linguist-generated=true
service/provisioning/internal.go linguist-generated=true
service/provisioning/model.go linguist-generated=true
service/qualitymonitorv2/api.go linguist-generated=true
service/qualitymonitorv2/impl.go linguist-generated=true
service/qualitymonitorv2/interface.go linguist-generated=true
service/qualitymonitorv2/internal.go linguist-generated=true
service/qualitymonitorv2/model.go linguist-generated=true
service/serving/api.go linguist-generated=true
service/serving/impl.go linguist-generated=true
service/serving/interface.go linguist-generated=true
service/serving/internal.go linguist-generated=true
service/serving/model.go linguist-generated=true
service/settings/api.go linguist-generated=true
service/settings/impl.go linguist-generated=true
service/settings/interface.go linguist-generated=true
service/settings/internal.go linguist-generated=true
service/settings/model.go linguist-generated=true
service/sharing/api.go linguist-generated=true
service/sharing/impl.go linguist-generated=true
service/sharing/interface.go linguist-generated=true
service/sharing/internal.go linguist-generated=true
service/sharing/model.go linguist-generated=true
service/sql/api.go linguist-generated=true
service/sql/impl.go linguist-generated=true
service/sql/interface.go linguist-generated=true
service/sql/internal.go linguist-generated=true
service/sql/model.go linguist-generated=true
service/vectorsearch/api.go linguist-generated=true
service/vectorsearch/impl.go linguist-generated=true
service/vectorsearch/interface.go linguist-generated=true
service/vectorsearch/internal.go linguist-generated=true
service/vectorsearch/model.go linguist-generated=true
service/workspace/api.go linguist-generated=true
service/workspace/impl.go linguist-generated=true
service/workspace/interface.go linguist-generated=true
service/workspace/internal.go linguist-generated=true
service/workspace/model.go linguist-generated=true
workspace_client.go linguist-generated=true
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ build: vendor

fmt:
@echo "✓ Formatting source code with goimports ..."
@go run golang.org/x/tools/cmd/goimports@0.34.0 -w $(shell find . -type f -name '*.go' -not -path "./vendor/*")
@go run golang.org/x/tools/cmd/goimports@v0.34.0 -w $(shell find . -type f -name '*.go' -not -path "./vendor/*")
@echo "✓ Formatting source code with gofmt ..."
@gofmt -w $(shell find . -type f -name '*.go' -not -path "./vendor/*")

Expand Down
4 changes: 3 additions & 1 deletion NEXT_CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# NEXT CHANGELOG

## Release v0.74.0
## Release v0.73.1

### New Features and Improvements

### Bug Fixes
* Revert custom serialization which introduced a bug
impacting nested query paramters in v0.73.0

### Documentation

Expand Down
166 changes: 21 additions & 145 deletions service/aibuilder/impl.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading