Skip to content

Fix version for the goimports in make fmt. #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parthban-db
Copy link
Contributor

@parthban-db parthban-db commented Jun 20, 2025

What changes are proposed in this pull request?

Fix version for the goimports in make fmt. Currently, we are missing a v before 0.34.0 in the version, which gives the following error: go: golang.org/x/tools/cmd/goimports@0.34.0: golang.org/x/tools/cmd/goimports@0.34.0: invalid version: unknown revision 0.34.0

How is this tested?

Tested Locally.

NO_CHANGELOG=true

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1236
  • Commit SHA: 9ea6a9539ec60ec00edc0dc8435c2f33e301b6b4

Checks will be approved automatically on success.

@parthban-db parthban-db enabled auto-merge June 20, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants