Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
A recent refactor of U2M logic to the SDK introduced a small bug where a hostname with a trailing slash would be rejected when using
databricks auth login
, e.g.databricks auth login --host https://myworkspace.cloud.databricks.com/
. This happens becauseAccountOAuthArgument
andWorkspaceOAuthArgument
both validate that the provided host does not have a trailing slash. Instead, we can tolerate hostnames ending with a slash by using theCanonicalHostName()
method ofConfig
to normalize the hostname, removing the unneeded trailing slash before passing the normalized hostname to U2M auth components. I have made a similar fix togetOidcEndpoints
.How is this tested?
Unit tests are added to verify that
getOauthArgument
onConfig
works with normalized hostnames, and same forgetOidcEndpoints
.