Skip to content

Fix example test names to comply with Go 1.24 vet checks #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Apr 7, 2025

What changes are proposed in this pull request?

This PR updates the names of many Example... functions in *_usage_test.go files across multiple service packages to comply with stricter vet rules introduced in Go 1.24.

  • WHAT: Renamed example functions so that their names match real exported identifiers.
  • WHY: In Go 1.24, the tests analyzer in go vet enforces that example function names must map to valid exported identifiers. These stricter checks caused previously valid tests to fail during go test, even though the actual test logic remained unchanged.

How is this tested?

Validated by running make test locally with Go 1.24. All example tests now pass without build or vet errors.

NO_CHANGELOG=true

@rauchy rauchy temporarily deployed to test-trigger-is April 7, 2025 11:45 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is April 7, 2025 11:45 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions bot Apr 7, 2025
@parthban-db
Copy link
Contributor

Can we start running our unit tests in go1.24?

@rauchy rauchy temporarily deployed to test-trigger-is April 16, 2025 07:42 — with GitHub Actions Inactive
@rauchy rauchy enabled auto-merge April 16, 2025 07:42
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1203
  • Commit SHA: 6c9adb3f0c2377c99677394d93134c878ab91af0

Checks will be approved automatically on success.

@rauchy rauchy temporarily deployed to test-trigger-is April 16, 2025 07:43 — with GitHub Actions Inactive
@rauchy rauchy added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 68499d8 Apr 16, 2025
15 checks passed
@rauchy rauchy deleted the fix-test-names branch April 16, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants