Skip to content

[Internal] Centralize API Client default settings + further decoupling #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 17, 2025

Conversation

renaudhartert-db
Copy link
Contributor

What changes are proposed in this pull request?

This PR further cleans-up the core code by centralizing API client default in httpclient and further decoupling config.Config from the API clients.

How is this tested?

Normal CI.

NO_CHANGELOG=true

@renaudhartert-db renaudhartert-db marked this pull request as ready for review March 17, 2025 12:48
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1174
  • Commit SHA: 75886b3eab9112b99022185a2ca00a1d5a69e18d

Checks will be approved automatically on success.

@renaudhartert-db renaudhartert-db added this pull request to the merge queue Mar 17, 2025
Merged via the queue into dev/sdk-mod with commit 9362036 Mar 17, 2025
16 checks passed
@renaudhartert-db renaudhartert-db deleted the renaud.hartert/clean-client3 branch March 17, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants