Skip to content

[Internal] Move all "core" packages in the "databricks" package. #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .codegen/_openapi_sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1668b0db17e23605f8c9d29fb3b674c01590732d
779817ed8d63031f5ea761fbd25ee84f38feec0d
10 changes: 0 additions & 10 deletions .mockery.yaml

This file was deleted.

32 changes: 32 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
# Version changelog

## [Release] Release v0.55.0

### Internal Changes

* Bump staticcheck to 0.5.1 and add go 1.23 test coverage ([#1106](https://github.com/databricks/databricks-sdk-go/pull/1106)).
* Bump x/net, x/crypto dependencies ([#1107](https://github.com/databricks/databricks-sdk-go/pull/1107)).
* Create custom codeql.yml ([#1114](https://github.com/databricks/databricks-sdk-go/pull/1114)).
* Decouple serving and oauth2 package ([#1110](https://github.com/databricks/databricks-sdk-go/pull/1110)).
* Migrate workflows that need write access to use hosted runners ([#1112](https://github.com/databricks/databricks-sdk-go/pull/1112)).
* Move package credentials in config ([#1115](https://github.com/databricks/databricks-sdk-go/pull/1115)).
* Update Queries test ([#1104](https://github.com/databricks/databricks-sdk-go/pull/1104)).


### API Changes:

* Added `NoCompute` field for [apps.CreateAppRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#CreateAppRequest).
* Added `HasMore` field for [jobs.BaseJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseJob).
* Added `HasMore` field for [jobs.BaseRun](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun).
* Added `PageToken` field for [jobs.GetJobRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#GetJobRequest).
* Added `HasMore` and `NextPageToken` fields for [jobs.Job](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Job).
* Added `HasMore` field for [jobs.Run](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run).
* Added `RunAs` field for [pipelines.CreatePipeline](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#CreatePipeline).
* Added `RunAs` field for [pipelines.EditPipeline](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#EditPipeline).
* Added `AuthorizationDetails` and `EndpointUrl` fields for [serving.DataPlaneInfo](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#DataPlaneInfo).
* [Breaking] Changed `Update` method for [a.AccountFederationPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#AccountFederationPolicyAPI) account-level service with new required argument order.
* [Breaking] Changed `Update` method for [a.ServicePrincipalFederationPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#ServicePrincipalFederationPolicyAPI) account-level service with new required argument order.
* Changed `UpdateMask` field for [oauth2.UpdateAccountFederationPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateAccountFederationPolicyRequest) to no longer be required.
* Changed `UpdateMask` field for [oauth2.UpdateServicePrincipalFederationPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateServicePrincipalFederationPolicyRequest) to no longer be required.
* [Breaking] Changed `DaysOfWeek` field for [pipelines.RestartWindow](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#RestartWindow) to type [pipelines.DayOfWeekList](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/pipelines#DayOfWeekList).

OpenAPI SHA: 779817ed8d63031f5ea761fbd25ee84f38feec0d, Date: 2025-01-08

## [Release] Release v0.54.0

### API Changes:
Expand Down
4 changes: 2 additions & 2 deletions account_client.go → databricks/account_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
2 changes: 1 addition & 1 deletion databricks/apierr/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"regexp"
"strings"

"github.com/databricks/databricks-sdk-go/common"
"github.com/databricks/databricks-sdk-go/databricks/common"
"github.com/databricks/databricks-sdk-go/databricks/httplog"
"github.com/databricks/databricks-sdk-go/databricks/log"
)
Expand Down
2 changes: 1 addition & 1 deletion databricks/apierr/errors_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"net/url"
"testing"

"github.com/databricks/databricks-sdk-go/common"
"github.com/databricks/databricks-sdk-go/databricks/common"
"github.com/stretchr/testify/assert"
)

Expand Down
2 changes: 1 addition & 1 deletion databricks/apierr/private_link.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"net/url"
"strings"

"github.com/databricks/databricks-sdk-go/common/environment"
"github.com/databricks/databricks-sdk-go/databricks/common/environment"
)

// Metadata about the private link product. Private link redirects users to the
Expand Down
4 changes: 2 additions & 2 deletions client/client.go → databricks/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"net/http"
"strings"

"github.com/databricks/databricks-sdk-go/config"
"github.com/databricks/databricks-sdk-go/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/config"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"golang.org/x/oauth2"
)

Expand Down
6 changes: 3 additions & 3 deletions client/client_test.go → databricks/client/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ import (
"strings"
"testing"

"github.com/databricks/databricks-sdk-go/config"
"github.com/databricks/databricks-sdk-go/databricks/apierr"
"github.com/databricks/databricks-sdk-go/internal/env"
"github.com/databricks/databricks-sdk-go/useragent"
"github.com/databricks/databricks-sdk-go/databricks/config"
"github.com/databricks/databricks-sdk-go/databricks/env"
"github.com/databricks/databricks-sdk-go/databricks/useragent"
"github.com/databricks/databricks-sdk-go/version"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 3 additions & 3 deletions config/api_client.go → databricks/config/api_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import (
"net/url"
"time"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/apierr"
"github.com/databricks/databricks-sdk-go/httpclient"
"github.com/databricks/databricks-sdk-go/useragent"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/useragent"
)

func (c *Config) NewApiClient() (*httpclient.ApiClient, error) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

"golang.org/x/oauth2"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/log"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"strings"
"testing"

"github.com/databricks/databricks-sdk-go/internal/env"
"github.com/databricks/databricks-sdk-go/databricks/env"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"golang.org/x/oauth2"
"golang.org/x/oauth2/clientcredentials"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/log"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import (
"fmt"
"time"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/log"
"github.com/databricks/databricks-sdk-go/httpclient"
"golang.org/x/oauth2"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"strings"
"testing"

"github.com/databricks/databricks-sdk-go/common/environment"
"github.com/databricks/databricks-sdk-go/httpclient/fixtures"
"github.com/databricks/databricks-sdk-go/databricks/common/environment"
"github.com/databricks/databricks-sdk-go/databricks/httpclient/fixtures"
"github.com/google/go-cmp/cmp"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (
"net/http"
"time"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/log"
"github.com/databricks/databricks-sdk-go/httpclient"
"golang.org/x/oauth2"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"time"

"github.com/databricks/databricks-sdk-go/databricks/apierr"
"github.com/databricks/databricks-sdk-go/databricks/httpclient/fixtures"
"github.com/databricks/databricks-sdk-go/databricks/log"
"github.com/databricks/databricks-sdk-go/httpclient/fixtures"
"github.com/stretchr/testify/require"
)

Expand Down
2 changes: 1 addition & 1 deletion config/auth_basic.go → databricks/config/auth_basic.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"fmt"
"net/http"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
)

type BasicCredentials struct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"path/filepath"
"strings"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/log"
"golang.org/x/oauth2"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"path/filepath"
"testing"

"github.com/databricks/databricks-sdk-go/internal/env"
"github.com/databricks/databricks-sdk-go/databricks/env"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"errors"
"fmt"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/log"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import (
"errors"
"testing"

"github.com/databricks/databricks-sdk-go"
"github.com/databricks/databricks-sdk-go/config"
"github.com/databricks/databricks-sdk-go/internal/env"
"github.com/databricks/databricks-sdk-go/databricks"
"github.com/databricks/databricks-sdk-go/databricks/config"
"github.com/databricks/databricks-sdk-go/databricks/env"
"github.com/stretchr/testify/assert"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"io/ioutil"
"os"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/log"
"golang.org/x/oauth2/google"
"google.golang.org/api/idtoken"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"fmt"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/log"
"golang.org/x/oauth2"
"google.golang.org/api/impersonate"
Expand Down
4 changes: 2 additions & 2 deletions config/auth_m2m.go → databricks/config/auth_m2m.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (
"golang.org/x/oauth2"
"golang.org/x/oauth2/clientcredentials"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/log"
"github.com/databricks/databricks-sdk-go/httpclient"
)

var errOAuthNotSupported = errors.New("databricks OAuth is not supported for this host")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"net/url"
"testing"

"github.com/databricks/databricks-sdk-go/httpclient/fixtures"
"github.com/databricks/databricks-sdk-go/databricks/httpclient/fixtures"
"github.com/stretchr/testify/require"
"golang.org/x/oauth2"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (
"net/url"
"time"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/log"
"github.com/databricks/databricks-sdk-go/httpclient"
"golang.org/x/oauth2"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"testing"
"time"

"github.com/databricks/databricks-sdk-go/httpclient"
"github.com/databricks/databricks-sdk-go/httpclient/fixtures"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/httpclient/fixtures"
"github.com/stretchr/testify/require"
)

Expand Down
2 changes: 1 addition & 1 deletion config/auth_pat.go → databricks/config/auth_pat.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"fmt"
"net/http"

"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
)

type PatCredentials struct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"sync"
"testing"

"github.com/databricks/databricks-sdk-go/internal/env"
"github.com/databricks/databricks-sdk-go/databricks/env"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
Expand Down
2 changes: 1 addition & 1 deletion config/azure.go → databricks/config/azure.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"strings"

"github.com/databricks/databricks-sdk-go/databricks/apierr"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/log"
"github.com/databricks/databricks-sdk-go/httpclient"
"golang.org/x/oauth2"
)

Expand Down
File renamed without changes.
File renamed without changes.
8 changes: 4 additions & 4 deletions config/config.go → databricks/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ import (
"sync"
"time"

"github.com/databricks/databricks-sdk-go/common"
"github.com/databricks/databricks-sdk-go/common/environment"
"github.com/databricks/databricks-sdk-go/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/common"
"github.com/databricks/databricks-sdk-go/databricks/common/environment"
"github.com/databricks/databricks-sdk-go/databricks/config/credentials"
"github.com/databricks/databricks-sdk-go/databricks/httpclient"
"github.com/databricks/databricks-sdk-go/databricks/log"
"github.com/databricks/databricks-sdk-go/httpclient"
"golang.org/x/oauth2"
)

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package config
import (
"testing"

"github.com/databricks/databricks-sdk-go/internal/env"
"github.com/databricks/databricks-sdk-go/databricks/env"
"github.com/stretchr/testify/assert"
)

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package config
import (
"strings"

"github.com/databricks/databricks-sdk-go/common/environment"
"github.com/databricks/databricks-sdk-go/databricks/common/environment"
)

func (c *Config) Environment() environment.DatabricksEnvironment {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package config
import (
"testing"

"github.com/databricks/databricks-sdk-go/common/environment"
"github.com/databricks/databricks-sdk-go/databricks/common/environment"
"github.com/stretchr/testify/assert"
)

Expand Down
4 changes: 2 additions & 2 deletions config/example_test.go → databricks/config/example_test.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package config_test

import (
"github.com/databricks/databricks-sdk-go"
"github.com/databricks/databricks-sdk-go/config"
"github.com/databricks/databricks-sdk-go/databricks"
"github.com/databricks/databricks-sdk-go/databricks/config"
)

func ExampleConfig_pat() {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading
Loading