Skip to content

Deprecate temp parameter in ChatDatabricks #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Deprecate temp parameter in ChatDatabricks #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b888c8b
.
bbqiu Mar 31, 2025
7ca2b45
.
bbqiu Mar 31, 2025
c144b66
.
bbqiu Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions integrations/langchain/src/databricks_langchain/chat_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class GetPopulation(BaseModel):
"""Name of Databricks Model Serving endpoint to query."""
target_uri: str = "databricks"
"""The target URI to use. Defaults to ``databricks``."""
temperature: Optional[float] = 0.0
temperature: Optional[float] = None
"""Sampling temperature. Higher values make the model more creative."""
n: int = 1
"""The number of completion choices to generate."""
Expand Down Expand Up @@ -252,15 +252,6 @@ def endpoint(self, value: str) -> None:

def __init__(self, **kwargs: Any):
super().__init__(**kwargs)
if "temperature" not in kwargs:
warnings.warn(
"Currently, temperature defaults to 0.0 if not specified. "
"In the next release, temperature will need to be explicitly set. "
"Please update your code to specify a temperature value. "
"Note: If you are using an o1 or o3 model, you need to set temperature=None.",
DeprecationWarning,
stacklevel=2,
)
self.client = get_deployment_client(self.target_uri)
self.extra_params = self.extra_params or {}

Expand Down