Allow filters to be defined when calling VS tool #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update default description Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Signed-off-by: Ann Zhang <ann.zhang@databricks.com> keep import Signed-off-by: Ann Zhang <ann.zhang@databricks.com> ruff Signed-off-by: Ann Zhang <ann.zhang@databricks.com> add dependency Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Signed-off-by: Ann Zhang <ann.zhang@databricks.com> fix Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> make required Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Signed-off-by: Ann Zhang <ann.zhang@databricks.com> update openai tests Signed-off-by: Ann Zhang <ann.zhang@databricks.com> format Signed-off-by: Ann Zhang <ann.zhang@databricks.com> else case Signed-off-by: Ann Zhang <ann.zhang@databricks.com> lint Signed-off-by: Ann Zhang <ann.zhang@databricks.com> improve unit tests Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
aravind-segu
approved these changes
May 1, 2025
| '- Pattern match: {"column LIKE": "word"} (matches full tokens separated by whitespace)\n' | ||
| '- OR logic: {"column1 OR column2": [value1, value2]} ' | ||
| "(matches if column1 equals value1 or column2 equals value2; matches are position-specific)" | ||
| ), |
There was a problem hiding this comment.
nit can also include this link if you think it will be useful: https://docs.databricks.com/aws/en/generative-ai/create-query-vector-search?language=Python%C2%A0SDK#use-filters-on-queries
There was a problem hiding this comment.
nvm didnt realize llm is getting passed this. So a link wont be useful
| if not name.startswith("__"): | ||
| columns.append((name, col_type, comment)) | ||
|
|
||
| return "The vector search index includes the following columns:\n" + "\n".join( |
annzhang-db
added a commit
that referenced
this pull request
May 7, 2025
Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
filtersthrough when invoking VS tool, and combine with filters defined at initialization time.How is this tested?
Langchain
OpenAI
LlamaIndex
