Skip to content

Add embedding model as resource #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025
Merged

Add embedding model as resource #101

merged 5 commits into from
Apr 15, 2025

Conversation

annzhang-db
Copy link
Contributor

@annzhang-db annzhang-db commented Apr 9, 2025

What changes are proposed in this pull request?

  • Adding the embedding model for databricks-managed embeddings to resources from index details

How is this tested?

  • Unit tests
  • Manual test
Screenshot 2025-04-09 at 6 54 40 PM

Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
@annzhang-db annzhang-db requested a review from aravind-segu April 9, 2025 22:28
Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Copy link
Contributor

@aravind-segu aravind-segu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the tests

@annzhang-db annzhang-db merged commit 92de525 into main Apr 15, 2025
6 checks passed
@annzhang-db annzhang-db deleted the embedding-model-resource branch April 15, 2025 03:20
annzhang-db added a commit that referenced this pull request May 7, 2025
Signed-off-by: Ann Zhang <ann.zhang@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants