refactor(query): Gracefully handle unknown GrantEntry objects in UserGrantSet::from_pb #18400
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Jul 22, 2025
11 tasks
🤖 Smart Auto-retry Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
TCeason
added a commit
to TCeason/datafuse
that referenced
this pull request
Jul 22, 2025
…Set::from_pb When an older version of the application processes `UserGrantSet` data that contains `GrantEntry` objects with newly introduced `GrantObject` types, the `GrantEntry::from_pb` conversion can fail for those specific entries. This commit modifies the `UserGrantSet::from_pb` function to gracefully handle such scenarios. If `GrantEntry::from_pb` returns an error (e.g., due to an unknown `GrantObject`), the error is now logged, and the problematic grant entry is skipped instead of causing the entire conversion to fail. This ensures that users on older versions can still log in and use their available grants, providing better forward compatibility and robustness against evolving data schemas. Without this, a user attempting to log in with data containing new `GrantObject` types would be prevented from logging in on an older client.
drmingdrmer
approved these changes
Jul 22, 2025
TCeason
force-pushed
the
user_grant_object_incompatible
branch
from
148a64d to
e7d4d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
When an older version of the application processes
UserGrantSetdata that containsGrantEntryobjects with newly introducedGrantObjecttypes, theGrantEntry::from_pbconversion can fail for those specific entries.This commit modifies the
UserGrantSet::from_pbfunction to gracefully handle such scenarios. IfGrantEntry::from_pbreturns an error (e.g., due to an unknownGrantObject), the error is now logged, and the problematic grant entry is skipped instead of causing the entire conversion to fail.This ensures that users on older versions can still log in and use their available grants, providing better forward compatibility and robustness against evolving data schemas.
Without this, a user attempting to log in with data containing new
GrantObjecttypes would be prevented from logging in on an older client.Tests
Type of change
This change is