Skip to content

refactor(query): support lazy read for update from #18394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Jul 19, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): support lazy read for update from

  • Add new setting nondeterministic_update_lazy_read_threshold
  • enable lazy read optimization when error_on_nondeterministic_update = 0

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jul 19, 2025
@zhang2014 zhang2014 added the ci-cloud Build docker image for cloud test label Jul 19, 2025
@zhang2014 zhang2014 requested a review from forsaken628 July 19, 2025 14:17
@zhang2014 zhang2014 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jul 19, 2025
Copy link
Contributor

Docker Image for PR

  • tag: pr-18394-d70169e-1752936678

note: this image tag is only available for internal use.

Copy link
Contributor

Docker Image for PR

  • tag: pr-18394-8e1d6a4-1752936735

note: this image tag is only available for internal use.

@zhang2014 zhang2014 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jul 20, 2025
Copy link
Contributor

Docker Image for PR

  • tag: pr-18394-23b5697-1752987620

note: this image tag is only available for internal use.

@zhang2014 zhang2014 force-pushed the refactor/lazy_read_update branch from 0a3b8a8 to 9cb9d55 Compare July 21, 2025 01:09
Copy link
Contributor

github-actions bot commented Jul 21, 2025

🤖 Smart Auto-retry Analysis

Workflow: 16406363695

📊 Summary

  • Total Jobs: 80
  • Failed Jobs: 22
  • Retryable: 0
  • Code Issues: 22

NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • linux / test_logs: Not retryable (Code/Test)
  • linux / sqllogic / standalone_minio (query, hybrid, parquet): Not retryable (Code/Test)
  • linux / sqllogic / standalone_minio (query, http, native): Not retryable (Code/Test)
  • linux / sqllogic / standalone_minio (query, hybrid, native): Not retryable (Code/Test)
  • linux / sqllogic / standalone_minio (query, http, parquet): Not retryable (Code/Test)
  • linux / sqllogic / ee (parquet): Not retryable (Code/Test)
  • linux / sqllogic / cluster (crdb, 2c8g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / cluster (query, 4c16g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / cluster (base, 2c8g, http): Not retryable (Code/Test)
  • linux / sqllogic / cluster (cluster, 2c8g, http): Not retryable (Code/Test)
  • linux / sqllogic / cluster (cluster, 2c8g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / standalone (query, 4c16g, http): Not retryable (Code/Test)
  • linux / sqllogic / cluster (query, 4c16g, http): Not retryable (Code/Test)
  • linux / sqllogic / standalone (crdb, 2c8g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / cluster (base, 2c8g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / standalone (base, 2c8g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / standalone (query, 4c16g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / standalone (crdb, 2c8g, http): Not retryable (Code/Test)
  • linux / sqllogic / standalone (base, 2c8g, http): Not retryable (Code/Test)
  • linux / sqllogic / cluster (crdb, 2c8g, http): Not retryable (Code/Test)
  • linux / sqllogic / standalone (standalone, 2c8g, hybrid): Not retryable (Code/Test)
  • linux / sqllogic / standalone (standalone, 2c8g, http): Not retryable (Code/Test)

🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

@zhang2014 zhang2014 marked this pull request as ready for review July 21, 2025 01:14
@zhang2014 zhang2014 marked this pull request as draft July 21, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cloud Build docker image for cloud test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant