-
Notifications
You must be signed in to change notification settings - Fork 794
feat(executor): add query execution stats #18345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d8a9c27
to
15ac573
Compare
Docker Image for PR
|
change table schema
15ac573
to
5696744
Compare
} | ||
} | ||
let worker_id = context.get_worker_id(); | ||
global.push_tasks(worker_id, Some(current_tasks), next_tasks); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This commit includes a minor fix unrelated to the PR's title.
Problem: Tasks were being incorrectly pushed to the current_tasks
queue here. It could cause a single task cost two points to be executed.
Solution: This change removes the redundant push to current_tasks, ensuring each task is cost one point. (Only occurred at steal_task_to_context
)
This reverts commit 5696744.
@@ -110,42 +110,3 @@ if [ "$response2_data" != "[]" ] && [ "$response2_data" != "null" ]; then | |||
else | |||
echo "✓ response2 data field is empty as expected" | |||
fi | |||
|
|||
# **External -> Internal**: should not reset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove a flaky test: This test need wait for acquiring all semaphares. It can correct acquire finally but the time is not sure.
0176290
to
2e6f3a1
Compare
Why not add it to system.processes? |
The key difference is that |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat(executor): add query execution stats
Tests
Type of change
This change is