Skip to content

fix: should not modify client query_id. #18322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jul 7, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

partially revert pr #17947:

  • not modify client query_id, since the id may be generated be client and used for route, let clients do the change themselves
  • query_ids generated by server continue to use uuid without -

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jul 7, 2025
@youngsofun youngsofun force-pushed the qid branch 3 times, most recently from 9070c36 to 245cc45 Compare July 7, 2025 07:57
since the id may be generated be client and used for route.
@youngsofun youngsofun merged commit 1c4a25a into databendlabs:main Jul 7, 2025
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants