Skip to content

feat: impl Task for private #18311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

KKould
Copy link
Member

@KKould KKould commented Jul 4, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Currently, Task-related functions rely on Cloud. This pr is used to support Task functions when privately deployed.

TODO:

  • Task
    • schedule
    • after
    • session_params
    • when
    • session_params
    • TaskRuns for log run state
  • Config to switch Cloud and Private
  • Store TaskRun on system table
  • Support scheduling by meta to avoid repeated query execution
  • Create Task
  • Describe Task
  • Alter Task
  • Drop Task
  • Show Tasks
  • Use table to record the direct dependencies of Task
  • System table: task_history

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - TODO

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

🤖 Smart Auto-retry Analysis (Retry 13)

Workflow: 16213987032

📊 Summary

  • Total Jobs: 80
  • Failed Jobs: 6
  • Retryable: 0
  • Code Issues: 6

NO RETRY NEEDED

All failures appear to be code/test issues requiring manual fixes.

🔍 Job Details

  • linux / test_unit: Not retryable (Code/Test)
  • linux / test_stateless_cluster: Not retryable (Code/Test)
  • linux / test_stateless_standalone: Not retryable (Code/Test)
  • linux / sqllogic / stage (s3, hybrid, sub_path, large): Not retryable (Code/Test)
  • linux / sqllogic / stage (fs, hybrid, full_path, large): Not retryable (Code/Test)
  • linux / sqllogic / stage (fs, hybrid, full_path, small): Not retryable (Code/Test)

🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

None => None,
Some(ref w) => Some(mt::WarehouseOptions {
warehouse: w.warehouse.clone(),
using_warehouse_size: w.using_warehouse_size.clone(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need warehouse_size?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with the current task structure defined by cloud, warehouse_options is rarely used in private

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants