Skip to content

chore: enable parquet encoding #12977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

chore: enable parquet encoding #12977

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a45c9cf
enable some encodings
dantengsky Oct 18, 2023
d2f5561
cargo fmt
dantengsky Oct 18, 2023
8ef8c76
Merge branch 'main' into chore-testing
BohuTANG Nov 4, 2023
8ad9788
Merge branch 'main' into chore-testing
dantengsky Jan 13, 2024
5cf3f8d
resovle merge conflict
dantengsky Jan 13, 2024
d71a01a
Merge branch 'main' into chore-testing
BohuTANG Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions src/query/storages/common/blocks/src/block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,26 @@ pub fn blocks_to_parquet(
}
}

fn col_encoding(_data_type: &ArrowDataType) -> Encoding {
// Although encoding does work, parquet2 has not implemented decoding of DeltaLengthByteArray yet, we fallback to Plain
// From parquet2: Decoding "DeltaLengthByteArray"-encoded required V2 pages is not yet implemented for Binary.
//
// match data_type {
// ArrowDataType::Binary
// | ArrowDataType::LargeBinary
// | ArrowDataType::Utf8
// | ArrowDataType::LargeUtf8 => Encoding::DeltaLengthByteArray,
// _ => Encoding::Plain,
//}
Encoding::Plain
fn col_encoding(data_type: &ArrowDataType) -> Encoding {
use databend_common_arrow::arrow::datatypes::DataType;
let lt = data_type.to_logical_type();
match lt {
DataType::Decimal(p, _) if *p <= 18 => Encoding::DeltaBinaryPacked,
DataType::UInt8
| DataType::UInt16
| DataType::UInt32
| DataType::UInt64
| DataType::Int8
| DataType::Int16
| DataType::Int32
| DataType::Date32
| DataType::Time32(_)
| DataType::Int64
| DataType::Date64
| DataType::Time64(_)
| DataType::Timestamp(_, _)
| DataType::Duration(_) => Encoding::DeltaBinaryPacked,

_ => Encoding::Plain,
}
}