fix: impl and get affected rowcount from resp data #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everpcpc
reviewed
Jun 12, 2025
driver/src/rest_api.rs
Outdated
| @@ -65,7 +65,10 @@ impl IConnection for RestAPIConnection { | |||
| async fn exec(&self, sql: &str) -> Result<i64> { | |||
| info!("exec: {}", sql); | |||
| let page = self.client.query_all(sql).await?; | |||
| Ok(page.stats.progresses.write_progress.rows as i64) | |||
|
|
|||
| let affected_rows = page.affected_rows().map_err(Error::InvalidResponse)?; | |||
There was a problem hiding this comment.
affected_rows and other helper functions could be located not in core but also in this impl. Then we could take advantages of query_iter.
There was a problem hiding this comment.
Maybe we can not take the advantage of query_iter when we parse the affected rows, because we need to query_all and use affected rows in the final page info.
There was a problem hiding this comment.
We could easily handle response in query_iter in driver rather than query_all in core.
There was a problem hiding this comment.
We could easily handle response in
query_iterin driver rather thanquery_allin core.
That sounds make sense.
There was a problem hiding this comment.
I mean we could make use of the value parser in driver.
hantmac
force-pushed
the
fix/impl-rowcount
branch
from
c0acbcc to
16d2dff
Compare
hantmac
changed the title
hantmac
force-pushed
the
fix/impl-rowcount
branch
from
cfd37ba to
5bde9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get affected_rows from response data.