[PLUGIN-1367] Fixed null pointer exception when sink schema is not set and SQL Engine Output is initialized. #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernst
requested review from
DJSagarAhire,
albertshau,
greeshmaswaminathan,
itsankit-google and
sanjanasandeep
fernst
changed the title
avirmani
reviewed
Sep 1, 2022
| Schema.Field.of("name", Schema.of(Schema.Type.STRING)), | ||
| Schema.Field.of("price", Schema.of(Schema.Type.DOUBLE)), | ||
| Schema.Field.of("dt", Schema.nullableOf(Schema.of(Schema.LogicalType.DATE))), | ||
| Schema.Field.of("bytedata", Schema.of(Schema.Type.BYTES)), |
There was a problem hiding this comment.
can you fix the tabs here, pls
avirmani
reviewed
Sep 1, 2022
| // Sink Pushdown is not supported if the sink schema is not defined. | ||
| if (tableSchema == null) { | ||
| LOG.debug("BigQuery SQL Engine Output was not initialized. Schema was empty."); | ||
| return; |
There was a problem hiding this comment.
so, this just means that bqexecute will not be pushed down for schemaless and will work in the old way, correct?
There was a problem hiding this comment.
BQ Execute is not a stage that can be "pushed down" in the traditional pipeline sense. BQ Execute operates on tables in BigQuery after the sink operation is completed.
Schemaless pipelines still work in Spark as they did before version 0.20 of the plugin / CDAP 6.7
avirmani
approved these changes
Sep 1, 2022
…and SQL Engine Output is initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.