Allow for the specification of auth scopes for google compute engine instances #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakenotjay
commented
Oct 1, 2025
jakenotjay
commented
- Adds the ability to specify authentication oauth2 scopes for an instance in google compute engine
- This allows for workers/schedulers to use their credentials to access other services e.g. artifact registry or secret manager for any work
jacobtomlinson
requested changes
Oct 2, 2025
There was a problem hiding this comment.
Broadly this looks great.
Instead of setting the defaults in code could you move them into the config.
Moved the definition into cloudprovider.yaml! |
jacobtomlinson
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.