Skip to content

add an example use of firestore #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

add an example use of firestore #240

merged 2 commits into from
Jun 11, 2025

Conversation

devoncarew
Copy link
Member

  • add an example use of firestore (example/example.dart)
  • add an API example to the readme

The example/example.dart file shows both simple value get and set, as well as an example of the streaming listen call.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

// generator doesn't yet parse the http proto annotations.
options: grpc.CallOptions(
metadata: {
'x-goog-request-params': 'database=$databaseId',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to replace this manual routing header w/ improvements to the grpc / protobuf generator so that it adds the necessary headers.

@devoncarew devoncarew requested a review from mosuem June 3, 2025 17:57
@@ -4,14 +4,15 @@ version: 0.1.0-wip
repository: https://github.com/dart-lang/labs/tree/main/pkgs/googleapis_firestore_v1

environment:
sdk: ^3.7.0
sdk: ^3.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for downgrading?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question; I actually forget. perhaps to retain the current (pre-3.7) formatting?

I'll keep this as is and roll separately w/ a general proto-regenerate PR.

@devoncarew devoncarew merged commit 4cc1f78 into main Jun 11, 2025
6 checks passed
@devoncarew devoncarew deleted the add_example branch June 11, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants