Skip to content

Skeleton for package:io_file #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 7, 2025
Merged

Conversation

brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Mar 7, 2025

  • dart create -t package io_file
  • updated README.md
  • add LICENSE
  • created workflow file
  • modify CHANGELOG.md and pubspec.yaml to version 0.1.0-wip
  • add a dependency on dart_flutter_team_lints
  • copy pkgs/io_file/analysis_options.yaml from dart-lang/http

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@brianquinlan brianquinlan marked this pull request as draft March 7, 2025 00:53
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:appengine 0.13.9 already published at pub.dev
package:gcloud 0.8.18 already published at pub.dev
package:io_file 1.0.0 ready to publish io_file-v1.0.0
package:native_synchronization 0.3.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@brianquinlan brianquinlan requested a review from natebosch March 7, 2025 19:12
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first pass through; mostly comments about the CI.

@@ -0,0 +1,23 @@
include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need / want this customization? You could also start w/ just dart_flutter_team_lints.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied these from dart-lang/http. They seem reasonable to me.

@brianquinlan brianquinlan removed the request for review from natebosch March 7, 2025 21:43
@brianquinlan
Copy link
Contributor Author

Thanks @devoncarew ! PTAL.

@brianquinlan brianquinlan marked this pull request as ready for review March 7, 2025 22:40
@brianquinlan brianquinlan merged commit ded28a4 into dart-lang:main Mar 7, 2025
12 checks passed
@@ -0,0 +1,12 @@
name: io_file
description: A starting point for Dart libraries or applications.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to update this description now (and the corresponding one on the root repo readme).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants