-
Notifications
You must be signed in to change notification settings - Fork 93
Testcontainer example #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
============================================
- Coverage 100.00% 54.84% -45.16%
============================================
Files 1 14 +13
Lines 6 330 +324
Branches 1 66 +65
============================================
+ Hits 6 181 +175
- Misses 0 131 +131
- Partials 0 18 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If you could sign your commits, that'll pass the DCO check. Do you think this should be in something more akin to a @dapr/dapr-test package instead of @dapr/dapr? |
2aac2c5
to
4dc2704
Compare
@WhitWaldo Commits are signed-off. The folder’s package.json’s name is currently “testcontainers” I think the published package name should be If dapr/js-sdk were already setup for npm workspaces (monorepo) then this could be published from there (here), but it isn’t setup that way currently, so I think this should be moved to a new repo: While I don’t think this is entirely out of place in the examples folder, where it is in this branch, it’s not achieving its full potential there. Once published, it can be advertised on the testcontainers contrib section along with the Dapr Testcontainer for Java that is already advertised there: |
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
4dc2704
to
599e93b
Compare
Description
Added Testcontainer as an example.
Ideally this should be a published package.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: