Skip to content

Testcontainer example #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

joebowbeer
Copy link
Contributor

Description

Added Testcontainer as an example.

Ideally this should be a published package.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.84%. Comparing base (d1bf38a) to head (599e93b).
Report is 30 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main     #701       +/-   ##
============================================
- Coverage   100.00%   54.84%   -45.16%     
============================================
  Files            1       14       +13     
  Lines            6      330      +324     
  Branches         1       66       +65     
============================================
+ Hits             6      181      +175     
- Misses           0      131      +131     
- Partials         0       18       +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WhitWaldo
Copy link
Contributor

If you could sign your commits, that'll pass the DCO check.

Do you think this should be in something more akin to a @dapr/dapr-test package instead of @dapr/dapr?

@joebowbeer
Copy link
Contributor Author

If you could sign your commits, that'll pass the DCO check.

Do you think this should be in something more akin to a @dapr/dapr-test package instead of @dapr/dapr?

@WhitWaldo Commits are signed-off.

The folder’s package.json’s name is currently “testcontainers”

I think the published package name should be @dapr/testcontainer

If dapr/js-sdk were already setup for npm workspaces (monorepo) then this could be published from there (here), but it isn’t setup that way currently, so I think this should be moved to a new repo: dapr/testcontainer-node

While I don’t think this is entirely out of place in the examples folder, where it is in this branch, it’s not achieving its full potential there. Once published, it can be advertised on the testcontainers contrib section along with the Dapr Testcontainer for Java that is already advertised there:

https://testcontainers.com/modules/dapr/

Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants