Fix dapr upgrade command incorrectly detecting HA mode for new version 1.15 #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that the scheduler by default uses 3 replicas, which incorrectly identified non-HA install as HA. Signed-off-by: Anton Troshin <anton@diagrid.io>
antontroshin
changed the title
mikeee
approved these changes
Feb 26, 2025
yaron2
added a commit
that referenced
this pull request
Mar 14, 2025
* use non-deprecated flags in List operation (#1478) Signed-off-by: yaron2 <schneider.yaron@live.com> * Scheduler: set broadcast address to localhost:50006 in selfhosted (#1480) * Scheduler: set broadcast address to localhost:50006 in selfhosted Signed-off-by: joshvanl <me@joshvanl.dev> * Set schedulder override flag for edge and dev Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> * Fix scheduler broadcast address for windows (#1481) Signed-off-by: Anton Troshin <anton@diagrid.io> * Remove deprecated flags (#1482) * remove deprecated flags Signed-off-by: yaron2 <schneider.yaron@live.com> * update Dapr version in tests Signed-off-by: yaron2 <schneider.yaron@live.com> --------- Signed-off-by: yaron2 <schneider.yaron@live.com> * Fix daprsystem configuration retrieval when renewing certificates (#1486) The issue found when similar resource were installed in k8s that use the name "configurations". In this case the knative's "configurations.serving.knative.dev/v1" was the last in the list and the command returned the error `Error from server (NotFound): configurations.serving.knative.dev "daprsystem" not found` Signed-off-by: Anton Troshin <anton@diagrid.io> * fix: arguments accept units (#1490) * fix: arguments accept units `max-body-size` and `read-buffer-size` now accept units as defined in the docs. Fixes #1489 Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: gofumpt Signed-off-by: Mike Nguyen <hey@mike.ee> * refactor: modify logic to comply with vetting Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: gofumpt -w . Signed-off-by: Mike Nguyen <hey@mike.ee> * refactor: set defaults `max-body-size` is defaulted to 4Mi `request-buffer-size` is defaulted to 4Ki This is inline with the runtime. Signed-off-by: Mike Nguyen <hey@mike.ee> * fix: set defaults in run and annotate Signed-off-by: Mike Nguyen <hey@mike.ee> * chore: gofumpt Signed-off-by: Mike Nguyen <hey@mike.ee> * refactor: exit with error rather than panic Co-authored-by: Anton Troshin <troll.sic@gmail.com> Signed-off-by: Mike Nguyen <hey@mike.ee> --------- Signed-off-by: Mike Nguyen <hey@mike.ee> Co-authored-by: Anton Troshin <troll.sic@gmail.com> * Fix scheduler pod count for 1.15 version when testing master and latest (#1492) Signed-off-by: Anton Troshin <anton@diagrid.io> * Fix podman CI (#1493) * Fix podman CI Update to podman 5.4.0 Signed-off-by: Anton Troshin <anton@diagrid.io> * fix --cpus flag Signed-off-by: Anton Troshin <anton@diagrid.io> --------- Signed-off-by: Anton Troshin <anton@diagrid.io> * Fix dapr upgrade command incorrectly detecting HA mode for new version 1.15 (#1494) * Fix dapr upgrade command detecting HA mode for new version 1.15 The issue is that the scheduler by default uses 3 replicas, which incorrectly identified non-HA install as HA. Signed-off-by: Anton Troshin <anton@diagrid.io> * Fix e2e Signed-off-by: Anton Troshin <anton@diagrid.io> --------- Signed-off-by: Anton Troshin <anton@diagrid.io> * Fix scheduler address for dapr run with file on Windows (#1497) Signed-off-by: Anton Troshin <anton@diagrid.io> * release: test upgrade/downgrade for 1.13/1.14/1.15 + mariner (#1491) * release: test upgrade/downgrade for 1.13/1.14/1.15 + mariner Signed-off-by: Mike Nguyen <hey@mike.ee> * fix: version skews Co-authored-by: Anton Troshin <troll.sic@gmail.com> Signed-off-by: Mike Nguyen <hey@mike.ee> * Update tests/e2e/upgrade/upgrade_test.go Accepted Co-authored-by: Anton Troshin <troll.sic@gmail.com> Signed-off-by: Yaron Schneider <schneider.yaron@live.com> * Update tests/e2e/upgrade/upgrade_test.go Co-authored-by: Anton Troshin <troll.sic@gmail.com> Signed-off-by: Yaron Schneider <schneider.yaron@live.com> * Fix downgrade issue from 1.15 by deleting previous version scheduler pods Update 1.15 RC to latest RC.18 Signed-off-by: Anton Troshin <anton@diagrid.io> * Fix downgrade 1.15 to 1.13 scenario with 0 scheduler pods Signed-off-by: Anton Troshin <anton@diagrid.io> * increase update test timeout to 60m and update latest version to 1.15 Signed-off-by: Anton Troshin <anton@diagrid.io> * fix httpendpoint tests cleanup and checks Signed-off-by: Anton Troshin <anton@diagrid.io> * make sure matrix runs appropriate tests, every matrix ran the same tests Signed-off-by: Anton Troshin <anton@diagrid.io> * skip TestKubernetesRunFile on HA Signed-off-by: Anton Troshin <anton@diagrid.io> * fix skip TestKubernetesRunFile on HA Signed-off-by: Anton Troshin <anton@diagrid.io> * update to latest dapr 1.15.2 Signed-off-by: Anton Troshin <anton@diagrid.io> * add logs when waiting for pod deletion Signed-off-by: Anton Troshin <anton@diagrid.io> --------- Signed-off-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: Anton Troshin <anton@diagrid.io> Co-authored-by: Anton Troshin <anton@diagrid.io> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Anton Troshin <troll.sic@gmail.com> * Fix dapr init test latest version retrieval (#1500) Lint Signed-off-by: Anton Troshin <anton@diagrid.io> * Fix downgrade stuck (#1501) * Fix goroutine channel leaks and ensure proper cleanup in tests Signed-off-by: Anton Troshin <anton@diagrid.io> * Add artificial delay before deleting scheduler pods during downgrade Signed-off-by: Anton Troshin <anton@diagrid.io> * Add timeout to helm upgrade tests, they are being stuck sometime for 5+ minutes Signed-off-by: Anton Troshin <anton@diagrid.io> * bump helm.sh/helm/v3 to v3.17.1 Signed-off-by: Anton Troshin <anton@diagrid.io> --------- Signed-off-by: Anton Troshin <anton@diagrid.io> --------- Signed-off-by: yaron2 <schneider.yaron@live.com> Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Anton Troshin <anton@diagrid.io> Signed-off-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Josh van Leeuwen <me@joshvanl.dev> Co-authored-by: Mike Nguyen <hey@mike.ee>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is that the scheduler by default uses 3 replicas, which incorrectly identified non-HA install as HA.
Issue reference
This fix should allow for PR #1491 to progress with testing newer version upgrade/downgrade
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: