Skip to content

Conversation

@xPucTu4
Copy link

@xPucTu4 xPucTu4 commented Feb 18, 2025

  • Added handling for ApiEmptySentence in ApiCommand.cs to return an empty list when the first response is empty.
  • Introduced !empty case in ApiConnection.cs to process empty responses.
  • Created ApiEmptySentence class to manage empty response types, enhancing API functionality.

Closes #103
This is a duplicate of PR #104 , recreated due to unintended additional changes in the original PR.

- Added handling for `ApiEmptySentence` in `ApiCommand.cs` to return an empty list when the first response is empty.
- Introduced `!empty` case in `ApiConnection.cs` to process empty responses.
- Created `ApiEmptySentence` class to manage empty response types, enhancing API functionality.
Copy link
Contributor

@Deantwo Deantwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks elegant and follows the same conventions as already used in the project.

@luposky
Copy link

luposky commented Mar 19, 2025

Hi,
Do you have any idea on the timing of the release of this version? For me it has become a blocker and it would be nice to have a new release of the library.

@Deantwo
Copy link
Contributor

Deantwo commented Mar 19, 2025

Hi, Do you have any idea on the timing of the release of this version? For me it has become a blocker and it would be nice to have a new release of the library.

The original maintainer of this project has been MIA for a few years now. So there likely won't be any updates to the original NuGet package, unless he suddenly returns.

But you can download the master from https://github.com/Deantwo/tik4net or https://github.com/xPucTu4/tik4net and compile it yourself instead, since they both have this and my other changes already.

@luposky
Copy link

luposky commented Mar 19, 2025

Thanks for the quick and precise answer, I was not aware of this fact, I would have waited months before realizing it.
Thanks again, I just add that as an end user it would be nice if someone published an updated version on nuget (maybe a tik4netv2) and continued this project.

@xPucTu4
Copy link
Author

xPucTu4 commented Mar 19, 2025

I actually published it a while ago:
SinisterDev.Tik4Net 3.5.19-pre - we use it in few active projects already
and
SinisterDev.Tik4Net 3.5.20-pre - changed targeting, needs testing

It's not showing up in searches because I haven’t had time to set up a public GitHub repo and a proper build/publish pipeline yet. If anyone is willing to help with this, it would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for !empty Response Type in API Queries (RouterOS v7.18)

3 participants