Update Django dependency to support Django 4 and 5 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danihodovic
approved these changes
Jul 4, 2024
|
Can you suppress the mypy warning that's failing CI? Add the below at the end of the line: status_code = ex.response.status_code # type: ignore |
|
I have added the |
|
I've pushed this to pypi as 0.0.12 https://pypi.org/project/django-webhook/#history. Thank you Robert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Django dependency to support both Django 4 and 5.
The
pyproject.tomlfile has been modified to allow Django versions >=4.0 and <6.0.This ensures compatibility with both Django 4 and the upcoming Django 5.1 release.
Additionally, the
poetry.lockfile has been updated to reflect these changes.Closes #27.